Alexandre Emsenhuber [Fri, 10 Feb 2012 17:00:21 +0000 (17:00 +0000)]
GOOD BYE $wgArticle!
It was stated that it would be removed in 1.20 and we are in 1.20.
Sam Reed [Fri, 10 Feb 2012 15:37:33 +0000 (15:37 +0000)]
Documentation followups from lastnight
Sam Reed [Fri, 10 Feb 2012 14:39:12 +0000 (14:39 +0000)]
* (bug 34313) MediaWiki API intro message about "HTML format" should mention the format parameter.
Sam Reed [Fri, 10 Feb 2012 14:27:50 +0000 (14:27 +0000)]
* (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.
mrbluesky [Fri, 10 Feb 2012 14:21:45 +0000 (14:21 +0000)]
Follow-up to r111150. Update parsertests, remove item from release notes.
mrbluesky [Fri, 10 Feb 2012 12:20:23 +0000 (12:20 +0000)]
(bug 32626) Add CSS class to backlinks in reference sections.
Aaron Schulz [Fri, 10 Feb 2012 01:35:13 +0000 (01:35 +0000)]
r111076: url decode the 'rel404' path...*ahem*. Archived files and files with special chars are otherwise broken.
Sam Reed [Fri, 10 Feb 2012 00:49:56 +0000 (00:49 +0000)]
Work in progress (can kill another patch hanging around in my working copy)
Maintenance script to kill off ancient tables, and drop old fields/indexes in tables
Includes cleanup of the text table, dropping it's old fields and indexes
More to come at a later date
Aaron Schulz [Fri, 10 Feb 2012 00:49:10 +0000 (00:49 +0000)]
Cleaned up some docs after r111101
Sam Reed [Fri, 10 Feb 2012 00:05:36 +0000 (00:05 +0000)]
Move config to 1.20 tooooo
Tim Starling [Thu, 9 Feb 2012 23:56:48 +0000 (23:56 +0000)]
Fix for r106752: let TempFSFile deletions happen when the object goes out of scope, as you would expect with this RAII pattern, rather than leaving it until shutdown. PHP has lots of bugs in its shutdown process so doing the file delete at scope destruction means it's more likely to happen.
Sam Reed [Thu, 9 Feb 2012 23:22:38 +0000 (23:22 +0000)]
* (bug 32341) Add upload by URL domain limitation.
Essentially reverts r109741 live again
Which was r109562, r109564, r109570
Sam Reed [Thu, 9 Feb 2012 21:36:14 +0000 (21:36 +0000)]
More return documentation
Sam Reed [Thu, 9 Feb 2012 21:35:05 +0000 (21:35 +0000)]
More return documentation
Sam Reed [Thu, 9 Feb 2012 21:33:27 +0000 (21:33 +0000)]
More return documentation
Sam Reed [Thu, 9 Feb 2012 21:17:18 +0000 (21:17 +0000)]
More documentation improvements
Sam Reed [Thu, 9 Feb 2012 21:08:06 +0000 (21:08 +0000)]
Fixing up undefined types in maintenance documentation
mrbluesky [Thu, 9 Feb 2012 21:06:19 +0000 (21:06 +0000)]
(bug 17416) Don't prompt for summary when summary is preset using &summary=
Raimond Spekking [Thu, 9 Feb 2012 21:05:06 +0000 (21:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Max Semenik [Thu, 9 Feb 2012 20:39:16 +0000 (20:39 +0000)]
(bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist. Now titles are fixed or deleted, if unfixable, upon loading Special:EditWatchlist.
Aaron Schulz [Thu, 9 Feb 2012 19:45:12 +0000 (19:45 +0000)]
(bug 34231) - 'Make thumb.php error or redirect for urls with bogus paths but valid file & thumb names.'
Sam Reed [Thu, 9 Feb 2012 19:30:01 +0000 (19:30 +0000)]
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
Sam Reed [Thu, 9 Feb 2012 19:29:36 +0000 (19:29 +0000)]
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
Jeroen De Dauw [Thu, 9 Feb 2012 19:14:25 +0000 (19:14 +0000)]
follow up to r111017 - up rel notes
Roan Kattouw [Thu, 9 Feb 2012 19:02:59 +0000 (19:02 +0000)]
Followup r110988: IE8 throws JS errors if you try to call .append() on a <style> tag (or try to change .innerHTML), so catch the error and fall back to replacing the style tag with a new one
Sam Reed [Thu, 9 Feb 2012 18:57:41 +0000 (18:57 +0000)]
Sync README up with Special:Version
Aaron Schulz [Thu, 9 Feb 2012 18:53:35 +0000 (18:53 +0000)]
Made loadFromFileCache() always disable $wgOut regardless of whether compression is used
Aaron Schulz [Thu, 9 Feb 2012 18:25:58 +0000 (18:25 +0000)]
Removed some $wgUseGzip comments...the LocalSettingsGenerator doesn't do this anymore
Sam Reed [Thu, 9 Feb 2012 18:01:54 +0000 (18:01 +0000)]
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
Sam Reed [Thu, 9 Feb 2012 18:01:10 +0000 (18:01 +0000)]
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
Aaron Schulz [Thu, 9 Feb 2012 17:54:14 +0000 (17:54 +0000)]
r111036: some doc tweaks
Sam Reed [Thu, 9 Feb 2012 17:42:35 +0000 (17:42 +0000)]
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
Sam Reed [Thu, 9 Feb 2012 17:41:50 +0000 (17:41 +0000)]
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
Antoine Musso [Thu, 9 Feb 2012 14:41:15 +0000 (14:41 +0000)]
reword doc from r110938
Antoine Musso [Thu, 9 Feb 2012 14:34:36 +0000 (14:34 +0000)]
DebugToolbar: drop specific monospace font
Use the defaults coming from skins/common/commonElements.css
ping r105122
Roan Kattouw [Thu, 9 Feb 2012 14:14:45 +0000 (14:14 +0000)]
Make mediawiki.legacy.ajax top-loading too, apparently some people are still using sajax on the live site. Eventually the legacy.ajax module should die entirely
Jeroen De Dauw [Thu, 9 Feb 2012 14:10:59 +0000 (14:10 +0000)]
follow up to r111017 - added docs
Roan Kattouw [Thu, 9 Feb 2012 11:04:24 +0000 (11:04 +0000)]
(bug 34289) user.options CSS loaded twice. Fixed by splitting off the CSS part of user.options into a separate module (user.cssprefs), as per the fixme comment added in r93363. No RELEASE-NOTEs because this is a regression fix that I'm gonna tag for backporting to 1.19
Antoine Musso [Thu, 9 Feb 2012 11:02:36 +0000 (11:02 +0000)]
(bug 34254) fix gzipped file cache double compressing output
A gzipped file cache is enabled by setting $wgUseGzip and $wgUseFileCache.
To save CPU cycles, HTMLFileCache would print the compressed output as is
but WebStart uses an ob_gzhandler so we end up with a double compression.
Roan Kattouw [Thu, 9 Feb 2012 10:59:52 +0000 (10:59 +0000)]
Revert r111023 and r111024, they broke user.options . I'll fix this properly by splitting user.options's CSS part into a separate module; I've apparently known this was needed since r93363
Antoine Musso [Thu, 9 Feb 2012 10:56:36 +0000 (10:56 +0000)]
debug statements for HTMLFileCache / Output
Roan Kattouw [Thu, 9 Feb 2012 10:42:53 +0000 (10:42 +0000)]
Explanatory comment for r111023
Roan Kattouw [Thu, 9 Feb 2012 10:36:12 +0000 (10:36 +0000)]
(bug 34289) user.options CSS loaded twice. Caused by r107534. Made embedded private modules scripts-only, because the styles for user.options are included separately in buildCssLinks(), because they need to be applied without JavaScript and because they need to respect $wgAllowUserCssPrefs. No RELEASE-NOTES because I want to merge this into 1.19 as a regression fix
Antoine Musso [Thu, 9 Feb 2012 09:34:47 +0000 (09:34 +0000)]
Fix some missing doc groups
Jeroen De Dauw [Thu, 9 Feb 2012 01:34:20 +0000 (01:34 +0000)]
put in r110285 again now that 1.19 branched
Sam Reed [Thu, 9 Feb 2012 01:21:02 +0000 (01:21 +0000)]
Followup r111006
Move config to 1.20 changes
Move release notes for reverted bugs from 1.19 to 1.20
Asher Feldman [Thu, 9 Feb 2012 01:18:32 +0000 (01:18 +0000)]
article_feedback migration included in wmf 1.19 deployment
Sam Reed [Thu, 9 Feb 2012 01:06:57 +0000 (01:06 +0000)]
Documentation and whitespace
Sam Reed [Thu, 9 Feb 2012 01:05:59 +0000 (01:05 +0000)]
Add 1.18 to HISTORY
Roan Kattouw [Thu, 9 Feb 2012 01:02:39 +0000 (01:02 +0000)]
Followup r110999: remove 1.19-specific stuff from the 1.20 release notes
Sam Reed [Thu, 9 Feb 2012 00:59:56 +0000 (00:59 +0000)]
Bump 1.20alpha
Sam Reed [Thu, 9 Feb 2012 00:24:11 +0000 (00:24 +0000)]
Blacklist | in windows paths too
Ping r110922
Roan Kattouw [Thu, 9 Feb 2012 00:10:50 +0000 (00:10 +0000)]
(bug 31676) Group dynamically inserted CSS into a single <style> tag, because IE limits the number of styles it'll apply to 32 (seriously?!?). 3rd party users were complaining about IE not applying some modules' CSS when many modules were loaded; this wasn't a problem on WMF wikis as far as I know
Aaron Schulz [Wed, 8 Feb 2012 23:25:58 +0000 (23:25 +0000)]
r110979: removed implode() call and format the message as plaintext, as any HTML will be escaped anyway for such exceptions.
Ian Baker [Wed, 8 Feb 2012 23:09:19 +0000 (23:09 +0000)]
Properly expand the "error storing file" message. Fixes bug 33846
Alexandre Emsenhuber [Wed, 8 Feb 2012 22:41:11 +0000 (22:41 +0000)]
Fix typo so that the key is set with correct value instead of a boolean with key "0"
Aaron Schulz [Wed, 8 Feb 2012 22:13:03 +0000 (22:13 +0000)]
* Corrected and improved FileBackend::getFileList() comments.
* Added unit tests for using getFileList() iterators twice.
Raimond Spekking [Wed, 8 Feb 2012 20:51:14 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Wed, 8 Feb 2012 20:34:24 +0000 (20:34 +0000)]
Bumped $maxContCacheSize to handle container sharding a bit better. However, wikis large enough to need sharding would probably have sane 404 handling anyway, which avoids the need to hit a bunch of containers in one request anyway (like rendering thumbnails on parse).
Sam Reed [Wed, 8 Feb 2012 20:20:13 +0000 (20:20 +0000)]
Gearman stuff hasn't been touched in 3 years
Aaron Schulz [Wed, 8 Feb 2012 19:53:55 +0000 (19:53 +0000)]
(bug 33374) - 'Deletion log summary not properly truncated'
Aaron Schulz [Wed, 8 Feb 2012 19:52:04 +0000 (19:52 +0000)]
Fixes for r96546 (bug 33167):
* Made LegacyLogFormatter try to respect the 'plaintext' parameter.
* Changed LogPage::addEntry() to use LogFormatter to get the action text as such calls to LogPage::actionText() are broken.
* Added comment to LogPage::actionText(). It's only OK to call this from the legacy log formatter, fetched via the proper factory functions.
* Converted CheckUser to using LogFormatter so that cuc_actiontext values work. Eventually, cuc_actiontext should be replaced with new cuc_params, cuc_log_type, and cuc_log_action fields, similar to the RC table.
Sam Reed [Wed, 8 Feb 2012 19:37:34 +0000 (19:37 +0000)]
Bug 34273 - get rid of dtrace example scripts
diediediediediediediediediediediediediediediedie
Max Semenik [Wed, 8 Feb 2012 18:07:41 +0000 (18:07 +0000)]
Fix my stupid mistake in r110750 that resulted in fake "can't delete page" errors (bug 34245)
Antoine Musso [Wed, 8 Feb 2012 17:03:43 +0000 (17:03 +0000)]
Fix doc for includes/upload
Antoine Musso [Wed, 8 Feb 2012 16:58:49 +0000 (16:58 +0000)]
fix doc grouping for actions
Antoine Musso [Wed, 8 Feb 2012 16:55:54 +0000 (16:55 +0000)]
Fix doc for maintenance/
Antoine Musso [Wed, 8 Feb 2012 16:49:53 +0000 (16:49 +0000)]
Fix doc for maintenance/benchmarks
Antoine Musso [Wed, 8 Feb 2012 15:51:16 +0000 (15:51 +0000)]
enhance filerepo doc structure
Alexandre Emsenhuber [Wed, 8 Feb 2012 15:23:09 +0000 (15:23 +0000)]
Fix comment, Profiler::getFunctionReport() no longer logs data itself.
Max Semenik [Wed, 8 Feb 2012 14:59:22 +0000 (14:59 +0000)]
Sort extension names on those lame Linux file systems:)
Antoine Musso [Wed, 8 Feb 2012 14:30:17 +0000 (14:30 +0000)]
rtrim() call does not pass by reference!
fix r110923
Antoine Musso [Wed, 8 Feb 2012 12:58:27 +0000 (12:58 +0000)]
debug messages for getFileListInternal() returns
Antoine Musso [Wed, 8 Feb 2012 12:16:32 +0000 (12:16 +0000)]
align variables / enhance comment
Antoine Musso [Wed, 8 Feb 2012 10:00:02 +0000 (10:00 +0000)]
debug statement for FileRepo::storeBatch()
also nicely align some variable assignements
Antoine Musso [Wed, 8 Feb 2012 09:54:44 +0000 (09:54 +0000)]
r110923 made basePath always null!
Antoine Musso [Wed, 8 Feb 2012 09:28:14 +0000 (09:28 +0000)]
align and sort class properties
Antoine Musso [Wed, 8 Feb 2012 09:21:19 +0000 (09:21 +0000)]
fix notice on construction without 'containerPaths'
The comment block seems to indicate that containerPaths should only be used
for backwards-compatibility, which implies it is optional.
The following code generated a notice:
$fsBackend = new FSFileBackend( array(
'name' => 'foo',
'lockManager' => 'fsLockManager',
'basePath' => '/tmp/foo',
);
Antoine Musso [Wed, 8 Feb 2012 09:16:19 +0000 (09:16 +0000)]
use rtrim() to strip trailing slashes
rtrim() can be given a list of character to strip from a given string.
Aaron Schulz [Wed, 8 Feb 2012 09:00:31 +0000 (09:00 +0000)]
Added some simple path validation to resolveContainerPath() in FSFileBackend. This makes file op batches a bit more robust.
Antoine Musso [Wed, 8 Feb 2012 07:03:20 +0000 (07:03 +0000)]
make gzopen() portable by using binary flag
r110871 forgot the 'b' flag which make sure gzopen handle file
content in binary form. That is for portability accross platforms.
Tim Starling [Wed, 8 Feb 2012 06:09:58 +0000 (06:09 +0000)]
* Optimise {{GENDER}} so that it doesn't need to load the user options if only one form is given. For some reason (presumably some detail of how translatewiki.net works) such {{GENDER}} invocations are extremely common.
* Updated Language::gender() documentation accordingly
Tim Starling [Wed, 8 Feb 2012 05:25:19 +0000 (05:25 +0000)]
Fixed a bug in User::loadOptions(), probably introduced in r49925, causing the User::loadOptions() query to be done after a cache load if the user had no option overrides at the time of cache save. Store an empty array to the cache's mOptionOverrides instead of null.
Tim Starling [Wed, 8 Feb 2012 03:27:49 +0000 (03:27 +0000)]
* Fix for r96546 etc.: due to a severe performance regression in log lists, removed {{GENDER}} invocations in logentry messages, replacing them with the default case.
* Manually fixed broken {{GENDER}} invocations in vi, eo, gu and ksh. Some amount of creativity was needed in the gu and ksh cases, these should be checked by translators.
* Fixed invocations of non-existent parser function "બહુવચન" in MessagesGu.php
* Apparently in the ksh case, the translator was confused between {{GRAMMAR}} and {{GENDER}}. Removed most instances pending translator review.
Tim Starling [Wed, 8 Feb 2012 00:03:16 +0000 (00:03 +0000)]
Revert r110321: introduces an XSS vulnerability because FormatJson::encode() does not prevent the termination of CDATA sections when JavaScript is embedded in HTML.
Aaron Schulz [Tue, 7 Feb 2012 23:57:33 +0000 (23:57 +0000)]
r96546: Made FeedUtils::formatDiff() use the new LogFormatter class rather than a broken LogPage::actionText() call (the <summary> tag only had the log action name in it). This change means that log actions in feeds now have the user name in them, unlike 1.18. Also, broke a long code line.
Aaron Schulz [Tue, 7 Feb 2012 23:12:17 +0000 (23:12 +0000)]
In LogFormatter:
* Changed LogFormatter to support displaying redacting log items if the context user can see them. The default mode is still "show only public items".
* Fixed static calls to non-static getRestrictedElement() function.
* Cleaned up LogFormatter that build up vars only to then throw them away and replace them with rev-deleted placeholders.
In RevDel_LogItem:
* Use LogFormatter instead of raw LogPage::actionText call as such calls are broken and just displayed things like the string "move" (the log action name) instead of "x moved a to b: reason" and such. Fixes r96546.
Aaron Schulz [Tue, 7 Feb 2012 22:22:27 +0000 (22:22 +0000)]
Made LogEntry::getPerformer() not fail miserable if we got the LogEntry via newFromRow() on just a logging table row. Previously, the current user IP would show.
Aaron Schulz [Tue, 7 Feb 2012 21:30:41 +0000 (21:30 +0000)]
Disable $wgDebugToolbar if file cache is turned on, as with $$wgShowIPinHeader
Antoine Musso [Tue, 7 Feb 2012 20:49:08 +0000 (20:49 +0000)]
drop comment about a removed parameter
Antoine Musso [Tue, 7 Feb 2012 20:47:45 +0000 (20:47 +0000)]
simplify FileCacheBase::fetchText
Implements a proposal by Tim on r98405 CR
Raimond Spekking [Tue, 7 Feb 2012 20:19:09 +0000 (20:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Tue, 7 Feb 2012 19:24:31 +0000 (19:24 +0000)]
Select fields returned by Revision::selectPageFields() and call Title::newFromRow() instead of Title::makeTitle() in Revision::getTitle() so that it doesn't need a separate query to load the page id or the latest revision id.
Antoine Musso [Tue, 7 Feb 2012 17:56:32 +0000 (17:56 +0000)]
add up comment for FileCache rewrite (r98698)
Sam Reed [Tue, 7 Feb 2012 16:49:34 +0000 (16:49 +0000)]
Merge r97508 changes to MessageCache.php and Skin.php into trunk
Antoine Musso [Tue, 7 Feb 2012 14:54:06 +0000 (14:54 +0000)]
test FileRepo constructor
Mark A. Hershberger [Tue, 7 Feb 2012 13:05:31 +0000 (13:05 +0000)]
w/s
Sam Reed [Tue, 7 Feb 2012 12:30:36 +0000 (12:30 +0000)]
Omg HTTPS
Ping r110822
Antoine Musso [Tue, 7 Feb 2012 11:50:31 +0000 (11:50 +0000)]
comment about wgShowIPinHeader disabling file cache
John Du Hart [Tue, 7 Feb 2012 11:03:30 +0000 (11:03 +0000)]
Fixes Bug 34243 - [Regression] Can't navigate from Special:ListUsers/sysop to other groups
Followup r97658